Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn when styleResources is used without the community module #4302

Merged
merged 4 commits into from Nov 9, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 9, 2018

related: #3994

As style-resources-loader causes huge performance problems and we cannot easily replace or remove it as it'd be a breaking change, we should put out a warning and a reference to the drop-in replacement (https://github.com/nuxt-community/style-resources-module).

The module will set build.styleResources to an empty object if used, so this warning will only pop up if you are not using the module.

Types of changes

  • Warning

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #4302 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4302      +/-   ##
==========================================
+ Coverage   90.96%   90.97%   +<.01%     
==========================================
  Files          56       56              
  Lines        1826     1828       +2     
  Branches      456      457       +1     
==========================================
+ Hits         1661     1663       +2     
  Misses        154      154              
  Partials       11       11
Impacted Files Coverage Δ
packages/webpack/src/builder.js 97.33% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4bd57...b271f74. Read the comment docs.

packages/webpack/src/builder.js Outdated Show resolved Hide resolved
pi0
pi0 previously approved these changes Nov 9, 2018
@pi0 pi0 merged commit 692493f into dev Nov 9, 2018
@manniL manniL deleted the chore-deprecate-style-resources branch November 10, 2018 00:00
@lock
Copy link

lock bot commented Dec 10, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants