Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use PascalCase for components name #4396

Merged
merged 2 commits into from Nov 24, 2018
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Nov 24, 2018

No description provided.

manniL
manniL previously approved these changes Nov 24, 2018
@manniL manniL changed the title chore: fix lint waraning for keep default recommended chore: fix lint warning for keep default recommended Nov 24, 2018
@manniL manniL changed the title chore: fix lint warning for keep default recommended chore: fix lint warning to keep default rules Nov 24, 2018
@clarkdo clarkdo changed the title chore: fix lint warning to keep default rules chore: fix lint warning to keep default rules[skip release] Nov 24, 2018
@clarkdo clarkdo force-pushed the vue-eslint branch 4 times, most recently from db6a166 to 1841512 Compare November 24, 2018 15:52
@codecov-io
Copy link

codecov-io commented Nov 24, 2018

Codecov Report

Merging #4396 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4396   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          56       56           
  Lines        1919     1919           
  Branches      482      482           
=======================================
  Hits         1752     1752           
  Misses        155      155           
  Partials       12       12
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b1b8e...975f4a2. Read the comment docs.

@clarkdo clarkdo changed the title chore: fix lint warning to keep default rules[skip release] refactor: use PascalCase for components name[skip release] Nov 24, 2018
@pi0 pi0 changed the title refactor: use PascalCase for components name[skip release] refactor: use PascalCase for components name Nov 24, 2018
@pi0 pi0 merged commit 52a92fb into nuxt:dev Nov 24, 2018
@MacZel
Copy link

MacZel commented Nov 27, 2018

This change introduces an issue. For example, I'm getting an error with <nuxt/> being changed to <Nuxt/> in https://github.com/nuxt/nuxt.js/blob/dev/examples/typescript/layouts/default.vue
If changed back to lowercase it runs smoothly.

Node:

ERROR  [Vue warn]: Invalid component name: "pages/index.vue". Component names can only contain alphanumeric characters and the hyphen, and must start with a letter.

Console:

[Vue warn]: Unknown custom element: <Nuxt> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

found in

---> <Default> at layouts/default.vue
       <Root>

@clarkdo
Copy link
Member Author

clarkdo commented Nov 27, 2018

@MacZel I'll have a look, thanks for the information.

@clarkdo
Copy link
Member Author

clarkdo commented Nov 27, 2018

@MacZel I've made some changes, could you have a try on latest dev branch ?

@MacZel
Copy link

MacZel commented Nov 27, 2018

@clarkdo I will try laetr this day and let you know

@manniL
Copy link
Member

manniL commented Nov 27, 2018

@MacZel Vue meta is already a dependency of nuxt itself

@MacZel
Copy link

MacZel commented Nov 27, 2018

@manniL My bad. Reinstalled the package and now everything is ok.
@clarkdo everything is running ok now

sdellenb added a commit to sdellenb/joybox that referenced this pull request Dec 6, 2018
This one has to wait until nuxt/nuxt#4396 is released.
@Jan10
Copy link

Jan10 commented Dec 20, 2018

@clarkdo
Copy link
Member Author

clarkdo commented Dec 20, 2018

@Jan10
Thanks for reminding, I'll change it back.

@clarkdo clarkdo deleted the vue-eslint branch April 2, 2019 13:16
@dzcpy
Copy link

dzcpy commented Jan 16, 2020

Actually, could you explain why use camel case instead of kebab case? What's the convension?
I can see that they use kebab case in Vue's official documentation, this inconsistancy made me a bit confused.
Is it only a habit thing or there's actually benefit?

@clarkdo
Copy link
Member Author

clarkdo commented Jan 17, 2020

@dzcpy
Copy link

dzcpy commented Jan 18, 2020

@clarkdo Thanks!

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants