Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): Add n-link and n-child components shortcuts #4525

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Dec 11, 2018

I do want the shortcuts :)

We will still support <nuxt-link> and <nuxt-child/> but I do recommend to document <n-link> and <n-child/> instead.

screenshot 2018-12-11 at 17 40 18

@codecov-io
Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #4525 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4525   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          61       61           
  Lines        2188     2188           
  Branches      527      527           
=======================================
  Hits         1994     1994           
  Misses        176      176           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a200f7...428c457. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea

@pi0 pi0 merged commit 1505197 into dev Dec 11, 2018
@Atinux Atinux deleted the feat-components-shortcuts branch December 11, 2018 17:23
@manniL
Copy link
Member

manniL commented Dec 11, 2018

Things to do:

  • Change all examples
  • Change documentation (base branch: 2.4)

@manniL
Copy link
Member

manniL commented Dec 11, 2018

Though it's already merged (but not released), I'd love to hear the opinion of the whole team on that ☺️

cc @aldarund @clarkdo @galvez

My opinion: I'm no fan of these shortcuts 🤷‍♂️ I wouldn't bother writing the 3 more letters for NuxtLink than losing a bit of "clarity" and "branding".

@clarkdo
Copy link
Member

clarkdo commented Dec 11, 2018

I think add one test for asserting origin and shortcut component is necessary.
About expamples, hello word shoud be enough, because nuxt-* are still official ones, they won’t be replaced by shortcuts.
In doc, we can add alias or shortcut field after component name.

@manniL
Copy link
Member

manniL commented Dec 11, 2018

So basically these are the two key questions:

  1. Should we add the aliases?
  2. Should we use them primarily in docs and examples?

If I got it right, @Atinux proposed to do both, 1 and 2.

@pi0
Copy link
Member

pi0 commented Dec 11, 2018

My suggestion is to keep primary names as official ones (For docs and examples), and just support aliases and IDE auto-completes. Try are not harmful and don't add runtime overhead (Same constructor)

@lock
Copy link

lock bot commented Jan 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants