New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-app): Add n-link and n-child components shortcuts #4525
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4525 +/- ##
=======================================
Coverage 91.13% 91.13%
=======================================
Files 61 61
Lines 2188 2188
Branches 527 527
=======================================
Hits 1994 1994
Misses 176 176
Partials 18 18 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea
Things to do:
|
I think add one test for asserting origin and shortcut component is necessary. |
So basically these are the two key questions:
If I got it right, @Atinux proposed to do both, 1 and 2. |
My suggestion is to keep primary names as official ones (For docs and examples), and just support aliases and IDE auto-completes. Try are not harmful and don't add runtime overhead (Same constructor) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I do want the shortcuts :)
We will still support
<nuxt-link>
and<nuxt-child/>
but I do recommend to document<n-link>
and<n-child/>
instead.