Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta headAttrs #4536

Merged
merged 2 commits into from Dec 14, 2018
Merged

feat: add meta headAttrs #4536

merged 2 commits into from Dec 14, 2018

Conversation

ricardogobbosouza
Copy link
Contributor

@ricardogobbosouza ricardogobbosouza commented Dec 12, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Add meta headAttrs

Checklist:

  • All new and existing tests are passing.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)

@manniL
Copy link
Member

manniL commented Dec 12, 2018

Hey @ricardogobbosouza 👋

As that options isn't documented in vue-meta we should documented it there first before providing an interface for it in Nuxt IMO.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #4536 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4536      +/-   ##
==========================================
+ Coverage   91.07%   91.07%   +<.01%     
==========================================
  Files          61       61              
  Lines        2184     2186       +2     
  Branches      527      527              
==========================================
+ Hits         1989     1991       +2     
  Misses        177      177              
  Partials       18       18
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 95.62% <100%> (+0.02%) ⬆️
packages/vue-renderer/src/spa-meta.js 85.45% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657a6cc...c2fe1dc. Read the comment docs.

@ricardogobbosouza
Copy link
Contributor Author

Hi @manniL, i agree
There is this option but it is not documented

@ricardogobbosouza
Copy link
Contributor Author

I created a PR nuxt/vue-meta#294

@manniL manniL requested a review from pi0 December 12, 2018 15:13
@manniL
Copy link
Member

manniL commented Dec 12, 2018

vue-meta PR merged.

@pi0
Copy link
Member

pi0 commented Dec 12, 2018

/ping @Atinux about release

@manniL
Copy link
Member

manniL commented Dec 12, 2018

@pi0 There is no vue-meta release necessary I think as just the docs were missing ☺️

@manniL
Copy link
Member

manniL commented Dec 12, 2018

@ricardogobbosouza Can you add a simple test (just modify one of the fixtures ;) to cover the change) please?

pi0
pi0 previously approved these changes Dec 12, 2018
@pi0
Copy link
Member

pi0 commented Dec 13, 2018

@manniL @ricardogobbosouza Shall we delegate example and tests to another PR or are you working on it? I don't want to make this enhancenemnt stalled.

galvez
galvez previously approved these changes Dec 13, 2018
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has gotten me before @ricardogobbosouza -- thanks!

@ricardogobbosouza
Copy link
Contributor Author

Hi @pi0
I'm taking tests today.

@ricardogobbosouza ricardogobbosouza dismissed stale reviews from galvez and pi0 via c2fe1dc December 14, 2018 11:43
@pi0 pi0 merged commit 9961453 into nuxt:dev Dec 14, 2018
@lock
Copy link

lock bot commented Jan 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants