New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add meta headAttrs
#4536
feat: add meta headAttrs
#4536
Conversation
Hey @ricardogobbosouza 👋 As that options isn't documented in vue-meta we should documented it there first before providing an interface for it in Nuxt IMO. |
Codecov Report
@@ Coverage Diff @@
## dev #4536 +/- ##
==========================================
+ Coverage 91.07% 91.07% +<.01%
==========================================
Files 61 61
Lines 2184 2186 +2
Branches 527 527
==========================================
+ Hits 1989 1991 +2
Misses 177 177
Partials 18 18
Continue to review full report at Codecov.
|
Hi @manniL, i agree |
I created a PR nuxt/vue-meta#294 |
vue-meta PR merged. |
/ping @Atinux about release |
@pi0 There is no vue-meta release necessary I think as just the docs were missing |
@ricardogobbosouza Can you add a simple test (just modify one of the fixtures ;) to cover the change) please? |
@manniL @ricardogobbosouza Shall we delegate example and tests to another PR or are you working on it? I don't want to make this enhancenemnt stalled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has gotten me before @ricardogobbosouza -- thanks!
Hi @pi0 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Types of changes
Description
Add meta
headAttrs
Checklist: