Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: disable extract-css-chunks-webpack-plugin in dev mode #4888

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 29, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix: #4885

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #4888 into dev will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #4888      +/-   ##
=========================================
- Coverage   91.8%   91.67%   -0.14%     
=========================================
  Files         72       72              
  Lines       2405     2401       -4     
  Branches     593      593              
=========================================
- Hits        2208     2201       -7     
- Misses       179      182       +3     
  Partials      18       18
Impacted Files Coverage Δ
packages/config/src/options.js 100% <100%> (ø) ⬆️
packages/utils/src/timer.js 96.42% <0%> (-3.58%) ⬇️
packages/utils/src/resolve.js 94% <0%> (-2.16%) ⬇️
packages/utils/src/route.js 99.17% <0%> (-0.83%) ⬇️
packages/utils/src/task.js 100% <0%> (ø) ⬆️
packages/utils/src/serialize.js 88.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bab9f...a4b86dc. Read the comment docs.

@pi0 pi0 merged commit 928a230 into nuxt:dev Jan 29, 2019
@pi0 pi0 mentioned this pull request Jan 29, 2019
clarkdo pushed a commit that referenced this pull request Jan 30, 2019
# Bugfixes 

* Handle `async` components correctly when using `nuxt-ts` (PR #4886)
* Fix `extractCSS` in `dev` mode (PR #4888)
* Correctly apply class when using `linkPrefetchedClass` (PR #4893)
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the disable-dev-extractcss branch April 2, 2019 13:06
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants