Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set linkPrefetchedClass #4893

Merged
merged 2 commits into from
Jan 30, 2019
Merged

fix: correctly set linkPrefetchedClass #4893

merged 2 commits into from
Jan 30, 2019

Conversation

phof
Copy link

@phof phof commented Jan 30, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Set the class name

Fix: #4882

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
    Minor change
  • All new and existing tests are passing.

@manniL manniL changed the title Fixes #4882 fix: correctly set linkPrefetchedClass Jan 30, 2019
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #4893 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4893   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          72       72           
  Lines        2406     2406           
  Branches      593      593           
=======================================
  Hits         2209     2209           
  Misses        179      179           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9788467...2e0ead5. Read the comment docs.

@clarkdo clarkdo merged commit 0088b33 into nuxt:dev Jan 30, 2019
@manniL
Copy link
Member

manniL commented Jan 30, 2019

Thanks ☺️

@manniL manniL mentioned this pull request Jan 30, 2019
clarkdo pushed a commit that referenced this pull request Jan 30, 2019
clarkdo pushed a commit that referenced this pull request Jan 30, 2019
# Bugfixes 

* Handle `async` components correctly when using `nuxt-ts` (PR #4886)
* Fix `extractCSS` in `dev` mode (PR #4888)
* Correctly apply class when using `linkPrefetchedClass` (PR #4893)
@phof phof deleted the fix_linkPrefetchedClass branch January 30, 2019 15:22
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If router.linkPrefetchedClass is set, the resulting class value is mangled
7 participants