Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cache-loader for external resources #4915

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 31, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix #4513

Disable cache-loader since it will omit url-loader/file-loader, this behaviour will lead to the fonts/images/vides which are less than 1K cannot be bundled.

And also webpack5 will be release soon, it will support cache feature internally, so it should be fine that apply current change for now.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from manniL and pi0 January 31, 2019 13:12
@codecov-io
Copy link

Codecov Report

Merging #4915 into dev will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4915      +/-   ##
==========================================
+ Coverage   91.79%   91.83%   +0.04%     
==========================================
  Files          73       73              
  Lines        2412     2412              
  Branches      593      593              
==========================================
+ Hits         2214     2215       +1     
+ Misses        180      179       -1     
  Partials       18       18
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.45% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.65% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb13b41...ac11acc. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #4915 into dev will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4915      +/-   ##
==========================================
- Coverage   91.79%   91.74%   -0.05%     
==========================================
  Files          73       73              
  Lines        2412     2412              
  Branches      593      593              
==========================================
- Hits         2214     2213       -1     
- Misses        180      181       +1     
  Partials       18       18
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.45% <ø> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.56% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb13b41...ac11acc. Read the comment docs.

@Atinux Atinux self-requested a review January 31, 2019 15:43
@pi0 pi0 merged commit 0223e56 into nuxt:dev Feb 1, 2019
@hojas
Copy link

hojas commented Mar 13, 2019

Is this released?

@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the cache-resource branch April 2, 2019 13:05
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev mode throws 404 for fonts if build.cache is enabled
8 participants