Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some small stuff #4979

Merged
merged 29 commits into from
Feb 8, 2019
Merged

refactor: some small stuff #4979

merged 29 commits into from
Feb 8, 2019

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 7, 2019

No description provided.

@manniL manniL added the WIP label Feb 7, 2019
@manniL manniL self-assigned this Feb 7, 2019
galvez
galvez previously approved these changes Feb 7, 2019
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this style :)

@manniL manniL changed the title refactor: flatten ifs refactor: some small stuff Feb 7, 2019
@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #4979 into dev will decrease coverage by 0.12%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4979      +/-   ##
==========================================
- Coverage   92.44%   92.31%   -0.13%     
==========================================
  Files          74       74              
  Lines        2461     2472      +11     
  Branches      608      608              
==========================================
+ Hits         2275     2282       +7     
- Misses        166      170       +4     
  Partials       20       20
Impacted Files Coverage Δ
packages/cli/src/commands/dev.js 72.41% <0%> (ø) ⬆️
packages/cli/src/commands/help.js 0% <0%> (ø) ⬆️
packages/generator/src/generator.js 100% <100%> (ø) ⬆️
packages/cli/src/run.js 72.22% <100%> (ø) ⬆️
packages/builder/src/builder.js 100% <100%> (ø) ⬆️
packages/server/src/server.js 94.25% <100%> (-0.07%) ⬇️
packages/vue-renderer/src/renderer.js 95.85% <100%> (ø) ⬆️
packages/server/src/middleware/error.js 97.87% <100%> (+0.04%) ⬆️
packages/cli/src/commands/build.js 80.95% <100%> (+0.95%) ⬆️
packages/utils/src/resolve.js 96.07% <100%> (-0.08%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0311bc...cdf8cd7. Read the comment docs.

husayt
husayt previously approved these changes Feb 8, 2019
Copy link
Contributor

@husayt husayt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat

Atinux
Atinux previously approved these changes Feb 8, 2019
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍
I love to see these refactors!

@manniL manniL removed the WIP label Feb 8, 2019
@manniL
Copy link
Member Author

manniL commented Feb 8, 2019

I hope CI passes (it did). If that's the case, I'm done 🙌

@Atinux Atinux merged commit 69dfd84 into dev Feb 8, 2019
@Atinux Atinux deleted the refactor/stuff branch February 8, 2019 16:25
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants