fix: generate failure

[karakum]

Allow to use [name].js?v=[contenthash] in chunk names.

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

In continuos of #3387 #4073
Resolves: #5006

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-io]

Codecov Report

Merging #5007 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #5007      +/-   ##
==========================================
+ Coverage   94.91%   94.92%   +0.01%     
==========================================
  Files          72       72              
  Lines        2400     2405       +5     
  Branches      607      608       +1     
==========================================
+ Hits         2278     2283       +5     
  Misses        102      102              
  Partials       20       20

Impacted Files	Coverage Δ
packages/webpack/src/plugins/vue/server.js	86.2% <100%> (+1.59%)	⬆️
packages/webpack/src/plugins/vue/util.js	72.72% <100%> (+6.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e7936...af0c596. Read the comment docs.

[karakum]

@manniL Who or what we are waiting for?

[manniL]

@karakum The PR hasn't even been on for 24 hours. Please be a little patient so that other team members have a chance to review the code as well ☺️

[manniL]

@karakum However, a fixture to test the correct behavior (and to therefore avoid regressions) would be highly appreciated 🙌

[Atinux]

I was writing my comment to ask you to add a fixture and a unit test...
Well you just made it before I clicked "comment" 👏

I'm good with the PR if the test are all green

[Atinux]

ESLint is broken: https://circleci.com/gh/nuxt/nuxt.js/29158?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Should we add a precommit hook for it @manniL @pi0 ?

[manniL]

@Atinux Yup, that's a great idea!

[karakum]

@Atinux All checks have passed! 😎

[clarkdo]

Could we move test to a existed fixture since a new fixture may increase more CI time consuming?

[karakum]

I think no.
Main settings

  build: {
    filenames: {
      app: '[name].js?v=[contenthash]',
      chunk: '[name].js?v=[contenthash]'
    }
  }

can't be turned on/off while unit-test, only just in whole fixture. Am I wrong?

[manniL]

@karakum Many thanks for your contribution 🙏

[galvez]

I was bit by this one -- many thanks @karakum :)