Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): reflect chainlable NuxtLoading methods #5104

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

matjaz
Copy link

@matjaz matjaz commented Feb 25, 2019

Built in NuxtLoading has chainable methods.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

https://github.com/nuxt/nuxt.js/blob/17cc12f0051c9666341ad79b4391d15fbf4355d6/packages/vue-app/template/components/nuxt-loading.vue#L75-L79

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL added the types label Feb 25, 2019
@manniL manniL changed the title NuxtLoading has chainable methods fix(types): reflect chainlable NuxtLoading methods Feb 25, 2019
@codecov-io
Copy link

codecov-io commented Feb 25, 2019

Codecov Report

Merging #5104 into dev will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #5104      +/-   ##
=========================================
- Coverage   95.08%     95%   -0.09%     
=========================================
  Files          72      72              
  Lines        2421    2421              
  Branches      614     614              
=========================================
- Hits         2302    2300       -2     
- Misses         99     101       +2     
  Partials       20      20
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.81% <0%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea0f86...f1466b1. Read the comment docs.

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @matjaz ! Changes sound logic, thanks !

@manniL manniL mentioned this pull request Feb 25, 2019
@Atinux Atinux merged commit 2bd9442 into nuxt:dev Feb 25, 2019
@matjaz matjaz deleted the patch-1 branch February 25, 2019 20:09
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants