-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove builder coupling from server #5157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
refactor(builder, server): reduce builder middleware coupling from server
refactor(builder, server): reduce builder coupling from server
Mar 4, 2019
😍😍😍 |
pi0
changed the title
refactor(builder, server): reduce builder coupling from server
refactor: remove builder coupling from server
Mar 4, 2019
Codecov Report
@@ Coverage Diff @@
## dev #5157 +/- ##
==========================================
- Coverage 96.57% 96.35% -0.23%
==========================================
Files 73 73
Lines 2456 2472 +16
Branches 619 626 +7
==========================================
+ Hits 2372 2382 +10
- Misses 69 75 +6
Partials 15 15
Continue to review full report at Codecov.
|
Good stuff, I can see where you're going with this :) |
galvez
previously approved these changes
Mar 5, 2019
manniL
reviewed
Mar 7, 2019
Did I see Chinese ? @pi0 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@nuxt/builder:builder.middleware()
and just keep a placeholder inside@nuxt/server
nuxt.ready()
in constructor anymorenuxt build
or whenoptions.server
isfalse