Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove builder coupling from server #5157

Merged
merged 31 commits into from
Mar 8, 2019
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 4, 2019

Changes:

  • Move middleware for dev (devMiddleware and hotMiddleware) into @nuxt/builder:builder.middleware() and just keep a placeholder inside @nuxt/server
  • Don't call nuxt.ready() in constructor anymore
  • Don't create a server during nuxt build or when options.server is false

@pi0 pi0 requested a review from clarkdo March 4, 2019 18:34
@pi0 pi0 added the WIP label Mar 4, 2019
@pi0 pi0 changed the title refactor(builder, server): reduce builder middleware coupling from server refactor(builder, server): reduce builder coupling from server Mar 4, 2019
@Atinux
Copy link
Member

Atinux commented Mar 4, 2019

😍😍😍

@pi0 pi0 changed the title refactor(builder, server): reduce builder coupling from server refactor: remove builder coupling from server Mar 4, 2019
@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #5157 into dev will decrease coverage by 0.22%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5157      +/-   ##
==========================================
- Coverage   96.57%   96.35%   -0.23%     
==========================================
  Files          73       73              
  Lines        2456     2472      +16     
  Branches      619      626       +7     
==========================================
+ Hits         2372     2382      +10     
- Misses         69       75       +6     
  Partials       15       15
Impacted Files Coverage Δ
packages/builder/src/builder.js 100% <ø> (ø) ⬆️
packages/cli/src/command.js 98.87% <ø> (ø) ⬆️
packages/webpack/src/builder.js 94.94% <100%> (+0.26%) ⬆️
packages/cli/src/commands/dev.js 88% <100%> (+0.5%) ⬆️
packages/cli/src/commands/build.js 86.36% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.84% <50%> (-0.95%) ⬇️
packages/server/src/server.js 97.72% <86.66%> (-2.28%) ⬇️
packages/core/src/nuxt.js 94.44% <88.23%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea8661...0ffcb4c. Read the comment docs.

@galvez
Copy link

galvez commented Mar 5, 2019

Good stuff, I can see where you're going with this :)

galvez
galvez previously approved these changes Mar 5, 2019
@pi0 pi0 removed the WIP label Mar 8, 2019
@clarkdo
Copy link
Member

clarkdo commented Mar 8, 2019

Did I see Chinese ? @pi0 😄

@pi0 pi0 added the WIP label Mar 8, 2019
@pi0 pi0 removed the WIP label Mar 8, 2019
@clarkdo clarkdo merged commit 13cb0f7 into dev Mar 8, 2019
@pi0 pi0 deleted the refactor/builder-middleware branch March 8, 2019 20:44
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants