Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-renderer): use async fs #5186

Merged
merged 6 commits into from
Mar 8, 2019
Merged

feat(vue-renderer): use async fs #5186

merged 6 commits into from
Mar 8, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 8, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Refactors to use async FS operations for vue-renderer. Some over-optimizations for early cleanup of MFS removed to reduce complexity, more consistency (not isMFS) and less dependency on webpack specific MFS implementation.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested a review from clarkdo March 8, 2019 09:37
@clarkdo
Copy link
Member

clarkdo commented Mar 8, 2019

We should await all build:resources hook call and remove isMfs as well 😃

@pi0
Copy link
Member Author

pi0 commented Mar 8, 2019

@clarkdo Promises are chained for hooks (Arrow function return shorthand)

@clarkdo
Copy link
Member

clarkdo commented Mar 8, 2019

@pi0 I mean the call of hook, like here, but it seemed all calls are await, so only removing isMFS is enough.

@codecov-io
Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #5186 into dev will increase coverage by 0.01%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5186      +/-   ##
==========================================
+ Coverage   96.52%   96.53%   +0.01%     
==========================================
  Files          72       73       +1     
  Lines        2447     2456       +9     
  Branches      620      619       -1     
==========================================
+ Hits         2362     2371       +9     
  Misses         70       70              
  Partials       15       15
Impacted Files Coverage Δ
packages/webpack/src/builder.js 94.68% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 95.26% <100%> (+0.44%) ⬆️
packages/server/src/server.js 100% <100%> (ø) ⬆️
packages/webpack/src/utils/async-mfs.js 90.9% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cbddeb...fbabeb8. Read the comment docs.

@clarkdo clarkdo merged commit d07aefa into dev Mar 8, 2019
@manniL manniL deleted the feat/async-vue-renderer branch March 8, 2019 12:43
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants