-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-renderer): use async fs #5186
Conversation
We should |
@clarkdo Promises are chained for hooks (Arrow function return shorthand) |
Codecov Report
@@ Coverage Diff @@
## dev #5186 +/- ##
==========================================
+ Coverage 96.52% 96.53% +0.01%
==========================================
Files 72 73 +1
Lines 2447 2456 +9
Branches 620 619 -1
==========================================
+ Hits 2362 2371 +9
Misses 70 70
Partials 15 15
Continue to review full report at Codecov.
|
Types of changes
Description
Refactors to use async FS operations for vue-renderer. Some over-optimizations for early cleanup of MFS removed to reduce complexity, more consistency (not
isMFS
) and less dependency on webpack specific MFS implementation.Checklist: