fix(builder): await for renderer to load resources #5341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how nuxt module tests are written:
With async-fs (#5186) we silently broke this because after awaiting
build()
we don't wait on renderer to load resources from fs and immediately requesting to the server causes tests failing.We didn't await because it is a webpack hook: https://github.com/nuxt/nuxt.js/blob/dev/packages/webpack/src/builder.js#L130
With this PR, for production build a
build:resources
hook will be emitted and awaited onbuild()
. This prevents breaking tests.