Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publicPath is not reactive in dev restarting #5227

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Mar 13, 2019

Fix #5216

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #5227 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5227      +/-   ##
==========================================
+ Coverage   96.33%   96.33%   +<.01%     
==========================================
  Files          73       73              
  Lines        2483     2484       +1     
  Branches      631      632       +1     
==========================================
+ Hits         2392     2393       +1     
  Misses         76       76              
  Partials       15       15
Impacted Files Coverage Δ
packages/server/src/middleware/modern.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320a46f...5d52933. Read the comment docs.

@clarkdo clarkdo requested a review from pi0 March 13, 2019 11:58
@Atinux Atinux self-requested a review March 13, 2019 14:56
@pi0 pi0 merged commit 1fb7538 into nuxt:dev Mar 13, 2019
@pi0 pi0 mentioned this pull request Mar 14, 2019
@clarkdo clarkdo deleted the public-path-reload branch April 2, 2019 13:12
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publicPath not reflect during nuxt dev
6 participants