Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loading screen #5251

Merged
merged 39 commits into from
Mar 20, 2019
Merged

feat: loading screen #5251

merged 39 commits into from
Mar 20, 2019

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Mar 15, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When running nuxt, you won't be able to access the url until the resources are available. This is really frustating and can also display this kind of error:
53035161-b50ab180-346c-11e9-8705-3d0942bf766d

After working with @pi0, we introduce a loading screen for Nuxt, a GIF is way better to understand 😄
Note: I am using the -o option at the end to automatically open the browser window

nuxt-loading-screen

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

manniL
manniL previously requested changes Mar 15, 2019
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback ☺️

packages/server/src/middleware/nuxt.js Outdated Show resolved Hide resolved
packages/vue-renderer/src/loading.html Outdated Show resolved Hide resolved
packages/vue-renderer/src/loading.html Outdated Show resolved Hide resolved
packages/vue-renderer/src/loading.html Outdated Show resolved Hide resolved
packages/vue-renderer/src/loading.html Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat(builder): Loading screen feat(builder): loading screen Mar 16, 2019
@pi0 pi0 requested a review from manniL March 16, 2019 12:43
@pi0
Copy link
Member

pi0 commented Mar 16, 2019

loading-screen moved to its own dedicated repository (because of packaging requirements)

https://github.com/nuxt/loading-screen

Thanks to @egoist for poi tool.

@pi0 pi0 requested review from aldarund, alexchopin, galvez, kevinmarrec and a team March 16, 2019 21:52
pi0
pi0 previously approved these changes Mar 16, 2019
clarkdo
clarkdo previously approved these changes Mar 16, 2019
galvez
galvez previously approved these changes Mar 17, 2019
manniL
manniL previously approved these changes Mar 18, 2019
@Atinux Atinux dismissed stale reviews from manniL, galvez, clarkdo, and pi0 via bc3fe28 March 18, 2019 17:55
@Atinux
Copy link
Member Author

Atinux commented Mar 18, 2019

I also updated the nuxt loading indicator for SPA:
nuxt-loading-indicator

It supports a theme key to 'dark' for the dark background :)
carbon (3)

@pi0 pi0 changed the title feat(builder): loading screen feat: loading screen Mar 19, 2019
@pi0 pi0 merged commit ef41e20 into dev Mar 20, 2019
@pi0 pi0 deleted the feat/build-ui branch March 20, 2019 09:18
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants