-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: loading screen #5251
Merged
Merged
feat: loading screen #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner and opening browser
manniL
previously requested changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback
pimlie
reviewed
Mar 15, 2019
loading-screen moved to its own dedicated repository (because of packaging requirements) |
pi0
previously approved these changes
Mar 16, 2019
clarkdo
previously approved these changes
Mar 16, 2019
galvez
previously approved these changes
Mar 17, 2019
manniL
previously approved these changes
Mar 18, 2019
pi0
approved these changes
Mar 19, 2019
This was referenced Mar 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When running
nuxt
, you won't be able to access the url until the resources are available. This is really frustating and can also display this kind of error:After working with @pi0, we introduce a loading screen for Nuxt, a GIF is way better to understand 😄
Note: I am using the
-o
option at the end to automatically open the browser windowChecklist: