fix(utils): handle serializeFunction edge case #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves edge cases where functions are serialized with a prefix of `function function`
aaronransley
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #5754 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 82 82
Lines 2662 2662
Branches 683 683
=====================================
Hits 2545 2545
Misses 98 98
Partials 19 19
Continue to review full report at Codecov.
|
galvez
approved these changes
May 16, 2019
galvez
changed the title
|
@aaronransley just please check this against 2.7.1 as I have a suspicion this may have been solved already. cc @pi0 |
|
@aaronransley k, cool, let's get this in then @pi0 I'll take a stab at rewriting serializeFunction using acorn to prevent further problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5001 and cases where functions are serialized with a prefix of
function functionTypes of changes
Description
This is a naive attempt at resolving #5001
I am not certain how to resolve the root issue with the function parsing code; the current code in serialize.js strikes me as requiring specific knowledge of how it was built. @galvez Perhaps you have ideas for a better fix?
Otherwise, I'm hopeful that this PR is helpful!
Checklist: