Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve changelog #5777

Merged
merged 1 commit into from
May 21, 2019
Merged

chore: improve changelog #5777

merged 1 commit into from
May 21, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 21, 2019

Example:

🐛 Bug Fix

💅 Refactors

📝 Examples

🏡 Chore

  • general
    • improve links in readme
  • ci
    • add flags for codecov

💖 Thanks to

  • Aaron Ransley
  • Alexandre David
  • Jun
  • Rafał Chłodnicki

@pi0 pi0 requested a review from a team May 21, 2019 19:01
@codecov-io
Copy link

codecov-io commented May 21, 2019

Codecov Report

Merging #5777 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5777   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          82       82           
  Lines        2662     2662           
  Branches      682      682           
=======================================
  Hits         2546     2546           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06cbe...6d98e7e. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #5777 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5777   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          82       82           
  Lines        2662     2662           
  Branches      682      682           
=======================================
  Hits         2546     2546           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06cbe...6d98e7e. Read the comment docs.

@clarkdo clarkdo merged commit 8a490d6 into dev May 21, 2019
@Atinux
Copy link
Member

Atinux commented May 21, 2019

I love it 😍

@manniL
Copy link
Member

manniL commented May 23, 2019

Amazing improvements! 👍

Would probably add the GH usernames after real names to the "extra thank you" section

@pi0
Copy link
Member Author

pi0 commented May 23, 2019

Thanks, @manniL. As we use git commits for generating changelog this would be a little hard to gather usernames unless GitHub provided an email -> username service. I'll search more to find a workaround meanwhile please let me know if have an idea for it and contrib welcome :)

@pi0 pi0 deleted the improve-changelog branch May 23, 2019 22:18
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants