Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue-renderer): safe format ssr logs #5764

Merged
merged 4 commits into from
May 19, 2019
Merged

fix(vue-renderer): safe format ssr logs #5764

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79f803f
fix: safe format ssr logs
May 19, 2019
3b4145b
revert test
May 19, 2019
f3df428
remove unnecessary check
May 19, 2019
6e80aba
simplify
May 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/vue-renderer/src/renderers/ssr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import path from 'path'
import crypto from 'crypto'
import { format } from 'util'
import fs from 'fs-extra'
import consola from 'consola'
import devalue from '@nuxt/devalue'
Expand Down Expand Up @@ -42,10 +43,15 @@ export default class SSRRenderer extends BaseRenderer {
const logs = []
const devReporter = {
log(logObj) {
if (logObj.args[0] instanceof Error) {
logObj.args[0] = logObj.args[0].stack
}
logs.push(logObj)
logs.push({
...logObj,
args: logObj.args.map((arg) => {
if (arg instanceof Error) {
return arg.stack
}
return format(arg)
})
})
}
}
consola.addReporter(devReporter)
Expand Down