Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-renderer): safe format ssr logs #5764

Merged
merged 4 commits into from
May 19, 2019
Merged

fix(vue-renderer): safe format ssr logs #5764

merged 4 commits into from
May 19, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 19, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

fixes #5763. console.log internally uses util.format to handle circular objects. After this change, we preserve it for SSR logs as well.

image

=>

image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from Atinux, pimlie and clarkdo May 19, 2019 12:32
@pi0 pi0 changed the title fix: safe format ssr logs fix(vue-renderer): safe format ssr logs May 19, 2019
clarkdo
clarkdo previously approved these changes May 19, 2019
Atinux
Atinux previously approved these changes May 19, 2019
pimlie
pimlie previously approved these changes May 19, 2019
Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thanks! :)

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #5764 into dev will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #5764      +/-   ##
=========================================
+ Coverage   95.6%   95.67%   +0.07%     
=========================================
  Files         82       82              
  Lines       2662     2660       -2     
  Branches     683      682       -1     
=========================================
  Hits        2545     2545              
+ Misses        98       97       -1     
+ Partials      19       18       -1
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <0%> (+0.03%) ⬆️
#unit 92.63% <0%> (+0.06%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 95.91% <0%> (+3.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb9f03...6e80aba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded due to SSR logs
6 participants