Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): wrong index and string in ssr log #5771

Merged
merged 1 commit into from
May 20, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented May 20, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  created() {
    console.log('created tet called', 1, true, {a: 1})
    console.log('I am pages/index.vue')
  }

Before:

image

After this pr:

image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 May 20, 2019 13:36
@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #5771 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5771      +/-   ##
==========================================
- Coverage   95.67%   95.64%   -0.04%     
==========================================
  Files          82       82              
  Lines        2660     2661       +1     
  Branches      682      683       +1     
==========================================
  Hits         2545     2545              
  Misses         97       97              
- Partials       18       19       +1
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.69% <0%> (-0.02%) ⬇️
#unit 92.59% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 94% <0%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7084b3a...87419f9. Read the comment docs.

@pi0 pi0 merged commit 106836f into nuxt:dev May 20, 2019
This was referenced May 21, 2019
@clarkdo clarkdo deleted the fix/ssr-string-log branch September 7, 2019 21:53
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants