Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove duplicate unit tests in packages/core/test/resolver… #5782

Merged
merged 1 commit into from
May 22, 2019

Conversation

cuixiaorui
Copy link

….test.js

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Remove duplicate unit tests in packages/core/test/resolver.test.js

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #5782 into dev will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5782      +/-   ##
==========================================
+ Coverage   95.64%   95.67%   +0.03%     
==========================================
  Files          82       82              
  Lines        2662     2662              
  Branches      682      682              
==========================================
+ Hits         2546     2547       +1     
+ Misses         98       97       -1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.71% <ø> (ø) ⬆️
#unit 92.63% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d811ef7...dda3f69. Read the comment docs.

@clarkdo clarkdo changed the title fix(core): Remove duplicate unit tests in packages/core/test/resolver… test: remove duplicate unit tests in packages/core/test/resolver… May 22, 2019
@clarkdo clarkdo merged commit b62585f into nuxt:dev May 22, 2019
@cuixiaorui cuixiaorui deleted the fix-core-resolver-test branch May 23, 2019 04:45
@pi0 pi0 mentioned this pull request May 25, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants