-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): only listen for file changes for supported extensions #5812
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5812 +/- ##
==========================================
+ Coverage 95.68% 95.72% +0.03%
==========================================
Files 82 82
Lines 2688 2687 -1
Branches 689 689
==========================================
Hits 2572 2572
+ Misses 98 97 -1
Partials 18 18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally tested. Works fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
Regarding Builder supportedExtensions
and incoming TypeScript refactors, I planned to make the array editable/extendable from nuxt.config
options. So that we can remove ts
and tsx
extensions from core and only extend with these 2 TS extensions through new refactored typescript
module.
Types of changes
Description
Eg listening on a directory without the supported file extensions could be prone to unnecessary reloads due to file changes which are not used by Nuxt. Eg
*.swp
,*~
or*.bak
files used by editorsChecklist: