Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-app): build indicator #5820

Merged
merged 24 commits into from
May 29, 2019
Merged

feat(vue-app): build indicator #5820

merged 24 commits into from
May 29, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 27, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Show build progress inside pages!

nuxt-hmr-indicator

TODO

  • improve style
  • support custom base URL
  • add an option to optionally disable
  • wait little more to display progress of 100

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: version: v2.8.0 docs#1421)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from Atinux and a team May 27, 2019 13:23
@codecov-io
Copy link

codecov-io commented May 27, 2019

Codecov Report

Merging #5820 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5820   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          82       82           
  Lines        2687     2687           
  Branches      689      689           
=======================================
  Hits         2571     2571           
  Misses         98       98           
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.42% <ø> (ø) ⬆️
#unit 92.66% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/vue-app/src/index.js 0% <ø> (ø) ⬆️
packages/config/src/config/build.js 100% <ø> (ø) ⬆️
packages/builder/src/context/template.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e161d70...55a1ead. Read the comment docs.

@Atinux
Copy link
Member

Atinux commented May 27, 2019

Awesome work Pooya!
Will do some small changes for the UI and will be good for me :)

packages/vue-app/template/components/nuxt-hmr.vue Outdated Show resolved Hide resolved
packages/vue-app/template/components/nuxt-hmr.vue Outdated Show resolved Hide resolved
packages/vue-app/template/components/nuxt-hmr.vue Outdated Show resolved Hide resolved
packages/vue-app/template/components/nuxt.js Outdated Show resolved Hide resolved
packages/vue-app/template/components/nuxt-hmr.vue Outdated Show resolved Hide resolved
@Atinux
Copy link
Member

Atinux commented May 28, 2019

My last commit improves the style and uses $nextTick to show 100% everytime it's built.

nuxt-hmr-indicator

@Atinux
Copy link
Member

Atinux commented May 28, 2019

I added the build.indicator: false option (true by default).

Test and documentation updates are needed now.

About option name, do we agree on build.indicator?

Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work guys :) !

@Atinux I'm fine with build.indicator, unless we decide it needs more context.

packages/config/types/build.d.ts Outdated Show resolved Hide resolved
@Atinux
Copy link
Member

Atinux commented May 28, 2019

UI changes to show only Nuxt logo + percent:
nuxt-hmr-indicator

@pi0 pi0 changed the title feat(vue-app): inline HMR progress indicator feat(vue-app): build indicator May 28, 2019
@pi0 pi0 requested a review from kevinmarrec May 28, 2019 17:55
@pi0
Copy link
Member Author

pi0 commented May 28, 2019

Updates:

  • Added name to component and renamed to buildIndicator
  • Smooth progress animation between updates
  • No more div wrapping

anim

@pi0 pi0 dismissed kevinmarrec’s stale review May 28, 2019 22:06

order is changed

@Atinux
Copy link
Member

Atinux commented May 29, 2019

Final GIF

nuxt-hmr-indicator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants