-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-app): build indicator #5820
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5820 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 82 82
Lines 2687 2687
Branches 689 689
=======================================
Hits 2571 2571
Misses 98 98
Partials 18 18
Continue to review full report at Codecov.
|
Awesome work Pooya! |
I added the Test and documentation updates are needed now. About option name, do we agree on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work guys :) !
@Atinux I'm fine with build.indicator
, unless we decide it needs more context.
Types of changes
Description
Show build progress inside pages!
TODO
Checklist: