feat: optionally strip non-client or non-server code #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What will happen to jsdom case？ |
Codecov Report
@@ Coverage Diff @@
## dev #6149 +/- ##
==========================================
- Coverage 95.79% 95.69% -0.11%
==========================================
Files 78 78
Lines 2714 2718 +4
Branches 702 706 +4
==========================================
+ Hits 2600 2601 +1
Misses 99 99
- Partials 15 18 +3
Continue to review full report at Codecov.
|
|
Made it optional but couldn't find a better name for it 🙈 |
clarkdo
reviewed
Jul 28, 2019
clarkdo
previously approved these changes
Jul 28, 2019
pi0
reviewed
Aug 4, 2019
| @@ -120,6 +120,12 @@ export default class WebpackBaseConfig { | |||
| 'process.mode': JSON.stringify(this.mode), | |||
| 'process.static': this.buildContext.isStatic | |||
| } | |||
| if (this.buildContext.buildOptions.aggressiveCodeRemoval) { | |||
| env['typeof process'] = JSON.stringify(this.isServer ? 'object' : 'undefined') | |||
There was a problem hiding this comment.
Values are the same. Can we refactor the right hand part to a const?
manniL
changed the title
pi0
approved these changes
Aug 21, 2019
galvez
approved these changes
Nov 24, 2019
Merged
This was referenced Mar 20, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
We already have
process.clientandprocess.serverthat take care of separating "client" and "server" code (if needed). However, it can sometimes be hard to control that in 3rd party dependencies.With this change, the webpack define plugin will set the
typeof windowcheck toobjecton client andundefinedon server, so the code can (and will be) correctly removed by webpack.Checklist: