Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting (non-essential) vue-meta options by user #6432

Merged
merged 4 commits into from Sep 18, 2019

Conversation

pimlie
Copy link

@pimlie pimlie commented Sep 18, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

With v2.3 vue-meta will introduce more non-essential plugin options. These options can also be set runtime, but it'd be nice if they could also just be set from the nuxt.config.

Adding the options to the SPA renderer doesnt have any useful effect for the moment, except maybe for setting a custom ssrAppId (which is ill-advised). So thats mostly included to be complete and maybe future vue-meta options.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #6432 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6432   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          79       79           
  Lines        2689     2689           
  Branches      694      694           
=======================================
  Hits         2571     2571           
  Misses        101      101           
  Partials       17       17
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.79% <ø> (ø) ⬆️
#unit 92.26% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/config/src/config/_app.js 100% <ø> (ø) ⬆️
packages/vue-renderer/src/renderers/spa.js 87.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9eddc...dca6d79. Read the comment docs.

@pimlie pimlie requested a review from a team September 18, 2019 09:29
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants