fix(cli): initialize server for build when there pages should be gene…

[aldarund]

…rated

fixes #6519

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

In spa mode we need to generate page, so hence need server to be initialized

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• [x ] All new and existing tests are passing.

[codecov-io]

Codecov Report

Merging #6525 into dev will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##              dev    #6525   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files          79       79           
  Lines        2706     2706           
  Branches      698      699    +1     
=======================================
  Hits         2589     2589           
  Misses        101      101           
  Partials       16       16

Flag	Coverage Δ
#e2e	100% <ø> (ø)	⬆️
#fixtures	50.59% <0%> (ø)	⬆️
#unit	92.38% <100%> (ø)	⬆️

Impacted Files	Coverage Δ
packages/cli/src/commands/build.js	86.36% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7688825...e04731f. Read the comment docs.

[clarkdo]

Initialise server in build will affect some functionalities which depend on runtime.

For example, modern will be detected at runtime and changed to false, so the modern build won't be triggered if you build more than once, and this issue was raised by @aldarund before.

Currently only enable it for generate should be safe, but maybe we can improve it in next minor release, like initialising server lazily just before rendering in generating, the the building phase won't be affected.

[pi0]

Thanks @clarkdo for clarifications. Can we probably keep an open issue for improvements?

[clarkdo]

#6531