Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(builder): analyze mode warning rewording #6924

Merged
merged 6 commits into from Feb 24, 2020
Merged

Conversation

markhoney
Copy link

The "analyze" build warning has been sitting on a screen in front of me for a while now, as I develop a site in Nuxt, and it's worded a little clumsily. Hopefully this fix is okay.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

The "analyze" build warning has been sitting on a screen in front of me for a while now, as I develop a site in Nuxt, and it's worded a little clumsily. Hopefully this fix is okay.
manniL
manniL previously requested changes Jan 28, 2020
Copy link
Member

@manniL manniL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improved wording ☺️

Could you fix the failing tests as well (changing the message there too)?
(packages/builder/test/builder.ctor.test.js)

@markhoney markhoney changed the title Fix analyze mode warning wording fix: analyze mode warning rewording Feb 3, 2020
@pi0 pi0 changed the title fix: analyze mode warning rewording chore(builder): analyze mode warning rewording Feb 24, 2020
@pi0 pi0 merged commit 084a1ca into nuxt:dev Feb 24, 2020
@pi0
Copy link
Member

pi0 commented Feb 24, 2020

Thanks @markhoney

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants