Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): allow background customization for default loading template #7162

Merged

Conversation

Geminii
Copy link

@Geminii Geminii commented Apr 1, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Relative to this MR to add the possibility to customize the background color for default loading indicator.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #7162 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7162   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files          84       84           
  Lines        3400     3400           
  Branches      928      928           
=======================================
  Hits         2136     2136           
  Misses       1017     1017           
  Partials      247      247           
Flag Coverage Δ
#unittests 62.82% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5515f...360e330. Read the comment docs.

@Geminii
Copy link
Author

Geminii commented Apr 7, 2020

@pi0 It seems test/audit got some problem independents of this PR.
It's possible to relaunch it and check this one ?
Thanks a lot :)

@clarkdo clarkdo requested a review from pi0 May 7, 2020 10:54
@pi0 pi0 changed the title fix(loading): add background customization into default loading template fix(vue-app): allow background customization for default loading template May 7, 2020
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pi0 pi0 merged commit a0db364 into nuxt:dev May 7, 2020
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants