Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store and replay vuex mutations for static target #7350

Merged
merged 4 commits into from
May 12, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 11, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR, records, and replays store mutations during client-side-navigation for the new full static target in order to allow updating (store) state with asyncData() and fetch()

Try locally:

yarn nuxt build test/fixtures/full-static
yarn nuxt export test/fixtures/full-static
yarn nuxt serve test/fixtures/full-static

Navigate to http://localhost:3000 and click on store link for testing CSR state restore.

You should see:

image

PS: This is the first use case of store mutations I've ever seen :D

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from Atinux and a team May 11, 2020 20:13
@pi0 pi0 merged commit 42406d6 into dev May 12, 2020
@pi0 pi0 deleted the feat/fullstatic-store branch May 12, 2020 11:05
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants