Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: components #7374

Merged
merged 11 commits into from
May 18, 2020
Merged

feat: components #7374

merged 11 commits into from
May 18, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 16, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

馃憖

Core fix: Don't use module handler fn name as unique key so we can do unique module check by default. This is important as one may add components module to modules/buildModules section

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from Atinux and kevinmarrec May 16, 2020 13:20
@pi0 pi0 changed the title Feat/components feat: components eyes May 16, 2020
@pi0 pi0 changed the title feat: components eyes feat: components May 16, 2020
kevinmarrec
kevinmarrec previously approved these changes May 16, 2020
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槏

@codecov-io
Copy link

codecov-io commented May 16, 2020

Codecov Report

Merging #7374 into dev will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7374      +/-   ##
==========================================
- Coverage   70.21%   70.19%   -0.03%     
==========================================
  Files          88       88              
  Lines        3670     3670              
  Branches     1000     1000              
==========================================
- Hits         2577     2576       -1     
- Misses        886      887       +1     
  Partials      207      207              
Flag Coverage 螖
#unittests 70.19% <83.33%> (-0.03%) 猬囷笍
Impacted Files Coverage 螖
packages/config/src/options.js 97.63% <50.00%> (-0.46%) 猬囷笍
packages/core/src/module.js 94.11% <100.00%> (-0.14%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7fa5fb0...ea982f7. Read the comment docs.

Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [release] when merging :)

@Atinux
Copy link
Member

Atinux commented May 18, 2020

Added the reference in upcoming docs: nuxt/docs@46c6ba8

@pi0 pi0 merged commit 6a6794e into dev May 18, 2020
@pi0 pi0 deleted the feat/components branch May 18, 2020 12:02
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants