Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(config): alias export to generate #7399

Merged
merged 2 commits into from
May 20, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 20, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

As of the new nuxt export command, it makes sense using export in nuxt.config. This alias is a backport from Nuxt3. After defaults getting applied, we keep the same references so any modifications to each, update another one

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested a review from Atinux May 20, 2020 15:33
@pi0 pi0 changed the title refactor: alias option.export to options.generate refactor(config): alias export to generate May 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #7399 into dev will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7399      +/-   ##
==========================================
+ Coverage   70.19%   70.21%   +0.02%     
==========================================
  Files          88       88              
  Lines        3670     3673       +3     
  Branches     1000     1001       +1     
==========================================
+ Hits         2576     2579       +3     
  Misses        887      887              
  Partials      207      207              
Flag Coverage Δ
#unittests 70.21% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
packages/config/src/options.js 97.66% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a4ca6...883cc02. Read the comment docs.

@Atinux Atinux merged commit 0bdc71c into dev May 20, 2020
@pi0 pi0 deleted the refactor/config-export branch May 20, 2020 15:43
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants