Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle router.base for crawler and serve #7486

Merged
merged 10 commits into from
Jun 10, 2020
Merged

fix: handle router.base for crawler and serve #7486

merged 10 commits into from
Jun 10, 2020

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Jun 9, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

router.base was not handled properly for the crawler and nuxt serve

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #7486 into dev will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7486      +/-   ##
==========================================
- Coverage   70.22%   70.20%   -0.02%     
==========================================
  Files          88       88              
  Lines        3714     3715       +1     
  Branches     1008     1008              
==========================================
  Hits         2608     2608              
- Misses        898      899       +1     
  Partials      208      208              
Flag Coverage Δ
#unittests 70.20% <0.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/cli/src/commands/serve.js 72.41% <ø> (ø)
packages/generator/src/generator.js 85.07% <ø> (ø)
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca3c76...7d437a6. Read the comment docs.

@pi0 pi0 merged commit 7c6e170 into dev Jun 10, 2020
@pi0 pi0 deleted the fix/router-base-export branch June 10, 2020 07:51
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants