Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modern): modulepreload not work in generate #7498

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jun 11, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This issue is reported by @kevinmarrec , it happened when we use generate and modern: true, as modern detection will be before building in generate, so this pr is excluding disalbing modern from static target.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from kevinmarrec and a team June 11, 2020 15:14
@codecov-commenter
Copy link

Codecov Report

Merging #7498 into dev will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7498      +/-   ##
==========================================
- Coverage   70.58%   70.18%   -0.41%     
==========================================
  Files          88       88              
  Lines        3604     3733     +129     
  Branches      977     1015      +38     
==========================================
+ Hits         2544     2620      +76     
- Misses        859      905      +46     
- Partials      201      208       +7     
Flag Coverage Δ
#unittests 70.18% <0.00%> (-0.41%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderer.js 0.00% <0.00%> (ø)
packages/config/src/load.js 77.90% <0.00%> (-16.22%) ⬇️
packages/server/src/middleware/error.js 95.23% <0.00%> (-3.07%) ⬇️
packages/config/src/options.js 95.23% <0.00%> (-2.85%) ⬇️
packages/generator/src/generator.js 85.07% <0.00%> (-1.60%) ⬇️
packages/webpack/src/plugins/vue/client.js 3.63% <0.00%> (-1.02%) ⬇️
packages/builder/src/builder.js 90.17% <0.00%> (-0.24%) ⬇️
packages/utils/src/cjs.js 69.69% <0.00%> (ø)
packages/cli/src/utils/config.js 100.00% <0.00%> (ø)
packages/cli/src/commands/serve.js 72.41% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f6b19...f2f3b47. Read the comment docs.

@clarkdo clarkdo merged commit 245d32d into dev Jun 12, 2020
@clarkdo clarkdo deleted the fix/generate-modern branch June 12, 2020 09:18
@pi0 pi0 mentioned this pull request Jun 12, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants