Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): encode routes and show error summary #7518

Merged
merged 11 commits into from
Jun 16, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 15, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Before:
image

After:
image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested a review from Atinux June 15, 2020 11:53
Atinux
Atinux previously approved these changes Jun 15, 2020
Copy link
Member

@Atinux Atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, for so long I was missing the error message 😅

@rajesh-h
Copy link

Hi Team,

I was unable to try this branch. Am I doing something wrong in my package.json?

Previous line - "nuxt-edge": "^2.13.0-26509786.618eb5fa",
I changed it as below
"nuxt": "nuxt/nuxtjs#fix/static-encode",

I get below error

ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.```

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #7518 into dev will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7518      +/-   ##
==========================================
+ Coverage   70.18%   70.21%   +0.02%     
==========================================
  Files          88       88              
  Lines        3737     3740       +3     
  Branches     1017     1017              
==========================================
+ Hits         2623     2626       +3     
  Misses        905      905              
  Partials      209      209              
Flag Coverage Δ
#unittests 70.21% <66.66%> (+0.02%) ⬆️
Impacted Files Coverage Δ
packages/generator/src/generator.js 85.29% <66.66%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed34199...3e11ad9. Read the comment docs.

@pi0
Copy link
Member Author

pi0 commented Jun 16, 2020

@rajesh-h Linking monorepo packages should be one by one and needs a build step. I would suggest waiting to merge and test with nuxt-edge :) Changes almost done trying to fix tests.

@pi0 pi0 merged commit 92ef65c into dev Jun 16, 2020
@pi0 pi0 deleted the fix/static-encode branch June 16, 2020 15:53
@pi0 pi0 mentioned this pull request Jun 16, 2020
@rajesh-h
Copy link

@rajesh-h Linking monorepo packages should be one by one and needs a build step. I would suggest waiting to merge and test with nuxt-edge :) Changes almost done trying to fix tests.

@pi0 Thank you very much for this info. I downloaded the latest nuxt-edge and I no more have that weird 404 for payload.js. Things look much better now thanks a lot.

I have observed another issue during generation, as I was not sure where I should be raising the issue I raised it under nuxt/content. nuxt/content#141

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants