Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: static target DX improvements #7712

Merged
merged 22 commits into from Jul 16, 2020
Merged

feat: static target DX improvements #7712

merged 22 commits into from Jul 16, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 13, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • With 2.13 we were making errors to force using nuxt export and nuxt serve for static target. Now instead users can keep using nuxt generate and nuxt start
  • export:* hooks deprecated to avoid using different names (generate will kept for nuxt3 too)
  • exports option is deprecated
  • Move smart build from nuxt/static to the core for nuxt generate for static target only (non breaking change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 assigned Atinux and pi0 Jul 13, 2020
@Atinux Atinux changed the title feat: startic target dx improvements feat: static target DX improvements Jul 13, 2020
@pi0 pi0 requested review from Atinux, clarkdo, manniL and a team July 15, 2020 11:11
@pi0 pi0 marked this pull request as ready for review July 15, 2020 11:19
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #7712 into dev will decrease coverage by 1.31%.
The diff coverage is 31.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7712      +/-   ##
==========================================
- Coverage   70.13%   68.82%   -1.32%     
==========================================
  Files          88       90       +2     
  Lines        3764     3820      +56     
  Branches     1025     1034       +9     
==========================================
- Hits         2640     2629      -11     
- Misses        913      968      +55     
- Partials      211      223      +12     
Flag Coverage Δ
#unittests 68.82% <31.09%> (-1.32%) ⬇️
Impacted Files Coverage Δ
packages/cli/src/utils/generate.js 0.00% <0.00%> (ø)
packages/config/src/config/generate.js 100.00% <ø> (ø)
packages/core/src/nuxt.js 93.18% <ø> (ø)
packages/vue-app/src/index.js 100.00% <ø> (ø)
packages/cli/src/commands/generate.js 88.23% <50.00%> (-5.52%) ⬇️
packages/generator/src/generator.js 86.22% <62.50%> (+0.93%) ⬆️
packages/cli/src/utils/serve.js 70.37% <70.37%> (ø)
packages/cli/src/commands/build.js 89.65% <100.00%> (ø)
packages/cli/src/commands/export.js 100.00% <100.00%> (ø)
packages/cli/src/commands/serve.js 100.00% <100.00%> (+27.58%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e537e8c...4b75f09. Read the comment docs.

@Atinux
Copy link
Member

Atinux commented Jul 16, 2020

I need to update articles & docs now :)

@pi0 pi0 merged commit c5a4465 into dev Jul 16, 2020
@pi0 pi0 deleted the feat/smart-build branch July 16, 2020 15:10
@pi0 pi0 mentioned this pull request Jul 22, 2020
@pi0 pi0 mentioned this pull request Jan 19, 2023
4 tasks
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants