fix(vue-app): handle fallback on generated page

[Atinux]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

This is an advances use case mentioned by @Akryum when you want a static fallback (not SPA) using a pages/404.vue and a Netlify redirect. Hitting an unknown page will fetch the wrong payload, this is why I use NUXT.routePath to fetch the generated page to fetch the payload.

@pi0 I am wondering if we should no directly remove _app.context.route.path directly in fetchPayload(NUXT.routePath || _app.context.route.path)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-commenter]

Codecov Report

Merging #7718 into dev will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##              dev    #7718   +/-   ##
=======================================
  Coverage   68.82%   68.83%           
=======================================
  Files          90       90           
  Lines        3820     3821    +1     
  Branches     1034     1034           
=======================================
+ Hits         2629     2630    +1     
  Misses        968      968           
  Partials      223      223           

Flag	Coverage Δ
#unittests	68.83% <50.00%> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
packages/cli/src/commands/generate.js	88.23% <ø> (ø)
packages/cli/src/commands/start.js	100.00% <ø> (ø)
packages/cli/src/utils/generate.js	0.00% <0.00%> (ø)
packages/cli/src/utils/serve.js	72.41% <66.66%> (+2.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361afcb...6d95a4b. Read the comment docs.

[pi0]

Also, is it also possible to add a redirect scenario to one of the test fixtures?

[Atinux]

Will do :)

[Atinux]

One thing also, because NUXT.routePath and _app.context.route.path are different, it will do a full render on client-side (like SPA fallback) because of https://github.com/nuxt/nuxt.js/blob/fix/fallback-with-404-page/packages/vue-app/template/client.js#L892