-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): include routes with children for generation #7761
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7761 +/- ##
==========================================
+ Coverage 68.83% 68.85% +0.02%
==========================================
Files 90 90
Lines 3821 3824 +3
Branches 1034 1034
==========================================
+ Hits 2630 2633 +3
Misses 968 968
Partials 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@pi0 I think one of previous tests is wrong, Look at these lines. This route should create three pages (exact behavior as https://github.com/nuxt/nuxt.js/pull/7761/files#diff-f20ead15adb68c21668ec1154f3ba2a2L44-R56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
flatRoutes
function was skip all parent routes that have children. Parent routes was not generates in static generation, to Take a look at #4562 to find more about the issue.close #4562 & #4982
Types of changes
Description
Checklist: