Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use nuxt everywhere #8210

Merged
merged 5 commits into from
Nov 30, 2020
Merged

refactor: use nuxt everywhere #8210

merged 5 commits into from
Nov 30, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 15, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

NuxtJS is nuxt company name. For consistency we can simply refer Nuxt everywhere unless it is about licensing, legal or products. Currently we use all 3 Nuxt.js/NuxtJS/Nuxt in different places which is so confusing.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 marked this pull request as ready for review November 30, 2020 22:34
Atinux
Atinux previously approved these changes Nov 30, 2020
clarkdo
clarkdo previously approved these changes Nov 30, 2020
@pi0 pi0 dismissed stale reviews from clarkdo and Atinux via 78401cd November 30, 2020 22:43
@pi0 pi0 merged commit c15fc42 into dev Nov 30, 2020
@pi0 pi0 deleted the refactor/nuxt branch November 30, 2020 22:44
@pi0 pi0 mentioned this pull request Nov 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants