fix(vue-app): triggerScroll when transitions is disabled #8225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
On a normal page change nuxt relies on the routeEnter hook of the transition to emit a triggerScroll event to resolve the scrollBehaviour: https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/App.js#L65
When you set
features.transitions: false
then this event is never emitted, so scrollBehaviour is broken. This pr fixes that by always emitting triggerScroll in fixPrepatch when you've setfeatures.transitions = false
The proposed change should work fine as the minifier should be able to remove the constant condition that exists when
transitions = false
Checklist: