Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): force chidren to be required if default child is present #8394

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

farnabaz
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This is a fix for #7823

Assume these pages:

- parent
  - index.vue
  - _slug.vue
- parent.vue

In the parent-child routes, if the parent has an index child, all other child routes with optional params should be treated as required to ensure the index child does load on /parent

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

Codecov Report

Merging #8394 (a2a07de) into dev (9ce75c5) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #8394      +/-   ##
==========================================
- Coverage   68.55%   68.51%   -0.04%     
==========================================
  Files          91       91              
  Lines        3876     3881       +5     
  Branches     1056     1058       +2     
==========================================
+ Hits         2657     2659       +2     
- Misses        991      993       +2     
- Partials      228      229       +1     
Flag Coverage Δ
unittests 68.51% <40.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/route.js 93.16% <40.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce75c5...a2a07de. Read the comment docs.

@pi0 pi0 requested review from Atinux and clarkdo November 25, 2020 14:19
@pi0 pi0 changed the title fix(route): force chidren to be required if default child is present fix(vue-app): force chidren to be required if default child is present Nov 30, 2020
@pi0 pi0 merged commit 7cac3c7 into nuxt:dev Nov 30, 2020
@pi0 pi0 mentioned this pull request Nov 30, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants