Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme #16

Merged
merged 8 commits into from
Apr 27, 2022
Merged

docs: update readme #16

merged 8 commits into from
Apr 27, 2022

Conversation

atinux
Copy link
Member

@atinux atinux commented Apr 27, 2022

Following #15

This is the ideal Readme I would like to see personally.

Regarding the module to work, we simply have to use import MyModule from '../src/module'; in the nuxt.config.ts, see https://stackblitz.com/edit/github-upewbw?file=playground%2Fnuxt.config.ts (this is what I do personally when working on a module) or maybe adding a "postinstall" script?

Open to suggestions 😊

See rendered version

@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuxt3-starter ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 11:32AM (UTC)

@pi0
Copy link
Member

pi0 commented Apr 27, 2022

Regarding the module to work, we simply have to use import MyModule from '../src/module'; in the nuxt.config.ts, see https://stackblitz.com/edit/github-upewbw?file=playground%2Fnuxt.config.ts (this is what I do personally when working on a module)

I would use src too but using main subpath has few benefits that makes types closer to what users expect and also allowing to test built module without changing playground...

@atinux
Copy link
Member Author

atinux commented Apr 27, 2022

What about adding a postinstall script?

@pi0
Copy link
Member

pi0 commented Apr 27, 2022

postinstall also happens when users of a nuxt module install the package. We probably don't want that for a normal module! (https://docs.npmjs.com/cli/v8/using-npm/scripts#npm-install). Shall we only provide online version for app starters for now?

Copy link
Member Author

atinux commented Apr 27, 2022

Make sense to not show the online playground for module creation for now

@pi0
Copy link
Member

pi0 commented Apr 27, 2022

v2 branch is restored too.

@atinux
Copy link
Member Author

atinux commented Apr 27, 2022

From what I see, the v2-stackblitz should be renamed to v2, it uses the <Tutorial> example and is working fine on both StackBlitz and CSB:

@pi0
Copy link
Member

pi0 commented Apr 27, 2022

I'm not sure how long we are going to keep v2 and v2-bridge but for same reason of v3-[platform], we can duplicate v2 to give platforms a permanent link keeping in their showcases.

@atinux
Copy link
Member Author

atinux commented Apr 27, 2022

Indeed, but v2 seems outdated, happy to duplicate v2-stackblitz to v2 and v2-codesandbox (+ add the sandbox.config.json)

@atinux
Copy link
Member Author

atinux commented Apr 27, 2022

Happy of this changes so far, I let you double check @pi0 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants