Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): active/inactive dropdown links #1407

Merged
merged 5 commits into from Mar 4, 2024

Conversation

zoobzio
Copy link
Contributor

@zoobzio zoobzio commented Feb 23, 2024

πŸ”— Linked issue

Resolves #982

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

UDropdown component was not applying active styles for internal URLs. Passing the isActive slot prop down from the parent NuxtLink component allows the item to be active if the item link is the current page. This will not effect existing functionality as the item can also be active from the HMenuItem component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

shinGangan and others added 2 commits February 23, 2024 17:40
…77f1 (#1405)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@benjamincanac benjamincanac merged commit 6a1142b into nuxt:dev Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown does not recognize active links
3 participants