-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Form): new component #439
Conversation
✅ Live Preview ready!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm very interested in this PR, but adding a dependency to 'zod' and 'Yup' seems out of context. Currently, I'm using Laravel as a backend, and I'd love to use that with Precognition. The dependencies, as set, will be present in the final build, even if we don't use them. |
@menthol Zod and Yup are only installed as dev dependencies in the main packages, and I used type only imports to make sure they won't be present in the final build. |
@benjamincanac the PR is ready to be reviewed. Let me know if you need additional information. |
@romhml I'll try to review this asap. I was just wondering like in the previous comments, do we really need to depend on |
How so? The |
Thanks! I'll have another go at it and improve the docs today or tomorrow |
Found it! I simply forgot to import defineComponent 🧑🎨 |
@romhml Thanks a lot for this PR, great work ! 😊 |
You're welcome! I'm genuinely passionate about the ecosystem and the incredible work your team is doing! Looking forward to contribute again 😊 |
Resolves #433
Fixes #438
The goal of this PR is to implement a Form component to validate and manage input error states. It currently features:
WDYT?