Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FormGroup): add slots #714

Merged
merged 21 commits into from
Sep 28, 2023
Merged

feat(FormGroup): add slots #714

merged 21 commits into from
Sep 28, 2023

Conversation

Levy-from-Odessa
Copy link
Contributor

@Levy-from-Odessa Levy-from-Odessa commented Sep 21, 2023 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #566, resolves #540

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added slots inside from group component for better customization

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel
Copy link

vercel bot commented Sep 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Sep 28, 2023 4:29pm

@Levy-from-Odessa Levy-from-Odessa changed the title Feat 566 form group Feat(566) added slots for form group Sep 21, 2023
@benjamincanac benjamincanac changed the title Feat(566) added slots for form group feat(FormGroup): add slots Sep 21, 2023
romhml
romhml approved these changes Sep 22, 2023
View reviewed changes
docs/content/3.forms/9.form-group.md Outdated Show resolved Hide resolved
@Levy-from-Odessa @romhml
Update docs/content/3.forms/9.form-group.md
8febc84 
Co-authored-by: Romain Hamel <rom.hml@gmail.com>
@benjamincanac Volta.net
Copy link
Member

I guess this solves #540 as well?

Levy-from-Odessa and others added 4 commits September 24, 2023 06:19
@Levy-from-Odessa @romhml
Update src/runtime/components/forms/FormGroup.vue
29d286a 
Co-authored-by: Romain Hamel <rom.hml@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
f7406db 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/components/content/examples/FormGroupErrorSlotExample.vue
9adfbdf 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
1a3e8af 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Levy-from-Odessa and others added 4 commits September 24, 2023 06:20
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
07ba274 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
32b96c6 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
542584f 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update docs/content/3.forms/9.form-group.md
a8a8baa 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@Levy-from-Odessa @benjamincanac
Update src/runtime/components/forms/FormGroup.vue
0a51943 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@benjamincanac benjamincanac merged commit 2fc9385 into nuxt:dev Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

@SCHrodrigo SCHrodrigo SCHrodrigo left review comments

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slots on UFormGroup [Feature Request] Allow Form Group's Hints to be passed as a slot instead of a prop.
4 participants
@Levy-from-Odessa @benjamincanac @romhml @SCHrodrigo