-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popper): arrow
option & docs consistency across components
#875
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
I think that's a great idea! It will still be customizable if anyone wants to change it, but for the default I think this will look better |
@benjamincanac seeing differences for the dark mode of these poppers. selectMenu - They are all the same for light mode - Do we want to make all those dark mode classes consistent? If so, which one would you prefer? |
I think it should adapt to the border of the component, we don't have to make them all the same π |
arrow
option & docs consistency across components
Thank you π |
π Linked issue
#873
β Type of change
π Description
Adding the arrow option to all components that use popper. This provides consistent popper options across these components. Docs for each of these components have been updated to demonstrate how to use the
popper
prop.Resolves #873
π Checklist