Improve automatic installation criteria #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 24.26% 24.26%
=======================================
Files 18 18
Lines 239 239
=======================================
Hits 58 58
Misses 181 181
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vue ecosystem, autoinstall feature is dedicated for cases when libraries are being included from CDN, instead of being bundled with the app. But testing for
Vuebeing globally available is not enough to correctly target these cases. It also triggers ifVueis made globally available e.g. with webpack'sProvidePlugin.Proposed solution avoids this problem. It's also used by vuex and vue-router.