Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not expose token in public runtime config #41

Merged
merged 3 commits into from Apr 11, 2023
Merged

fix: do not expose token in public runtime config #41

merged 3 commits into from Apr 11, 2023

Conversation

danielroe
Copy link
Collaborator

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This only seems to be used in a server route, but we are leaking it in rendered HTML.

const gq = graphql.defaults({
headers: {
authorization: `token ${options.token}`
}
})

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 11, 2023
@danielroe danielroe requested a review from Atinux April 11, 2023 09:50
@danielroe danielroe self-assigned this Apr 11, 2023
@netlify
Copy link

netlify bot commented Apr 11, 2023

❌ Deploy Preview for nuxt-github-module failed.

Name Link
πŸ”¨ Latest commit f1db5b7
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt-github-module/deploys/64352ed7caa6ef0008eebfaa

@Atinux Atinux merged commit 5490c43 into main Apr 11, 2023
1 of 6 checks passed
@Atinux Atinux deleted the fix/token branch April 11, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants