New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't rely on presence of `@nuxt/ui-templates` #66

Merged

farnabaz merged 1 commit into main from fix/ui-templates

May 3, 2024

Contributor

danielroe commented May 3, 2024 •

edited

Loading

Several fixes in this PR:

Don't rely on @nuxt/ui-templates being present in the repo. We've recently removed it and this is breaking projects using nuxt-component-meta: see https://github.com/nuxt/ecosystem-ci/actions/runs/8934318864
We don't need to resolve nuxt/app as it is already set in nuxt.options.appDir
We can resolve both paths up-front and improve performance as it no longer has to run each time that components:dirs is called.


          fix: don't rely on presence of @nuxt/ui-templates

4c5936f

danielroe added the bug label

danielroe requested review from atinux and farnabaz

May 3, 2024 10:51

danielroe self-assigned this

farnabaz approved these changes

View reviewed changes

farnabaz merged commit 5b8f450 into main

farnabaz deleted the fix/ui-templates branch

May 3, 2024 10:57

danielroe mentioned this pull request

Error: Cannot find module '@nuxt/ui-templates' nuxt/nuxt#27592

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug