Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Character Information in translation system #32

Closed
CyrilleB79 opened this issue Jun 1, 2021 · 20 comments
Closed

Register Character Information in translation system #32

CyrilleB79 opened this issue Jun 1, 2021 · 20 comments

Comments

@CyrilleB79
Copy link
Contributor

Could you please register Character Information in the translation system? This add-on is already present on the official add-on community website.

GitHub repo URL:
https://github.com/CyrilleB79/charInfo

The files to be synchronized are the interface file (.po) as well as the documentation (.md), as for other add-ons.

Note: The translation of localized files specific to this add-on (found in addon/globalPlugins/charinfo/locale/xx) should not be localized via this automatic translation framework. Instead, localization of these files should be done directly via PR's in the charInfo add-on's repo or contacting the add-on author (me).

@CyrilleB79
Copy link
Contributor Author

Additional note:
For now, I have manual French translations in addon/doc and addon/locale. Let me know if I should remove the translated files from these folders. Thanks.

@feerrenrut
Copy link
Contributor

I can't give advice on these questions at this stage. Please follow the same procedure as other addon's.

@CyrilleB79
Copy link
Contributor Author

@nvdaes any thought? You were used to register add-ons in the past.
I guess I should remove the existing translations in stable branch; that's not a problem for me provided the various steps of the workflow do not require too much time to be validated.
Could you confirm it so that I can proceed? Thanks.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 21, 2021 via email

@CyrilleB79
Copy link
Contributor Author

Indeed, I had already asked the inclusion of this add-on in the translation framework on the add-on mailing list. And here was your answer 😕:

About how to register new add-ons in the system, Reef requested me to
open an issue (I requested to register PC Keyboard Braille Input
add-on), and Reef's request was also intended to study the details of
the system (originally created by Mesar). Reef's request can be found
in issue 3 of the mr config repo, and the issue created by me is at

#30

The full thread can be read here.

Anyway, I have removed the existing French translations. Please let me know here or in the corresponding thread of the mailing list if something is still required on my side for the creation of the fork in the community repo.
Thanks.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 21, 2021 via email

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 21, 2021

@CyrilleB79 , I've created the needed fork of the repo on nvdaaddons organization and has sent you an invitation as a collaborator with write access in the fork, so you can manage the stable branch ensuring that the messages to be translated are updated there.
@feerrenrut or NV Access staff, you can activate the translation in the server.
Thanks

@CyrilleB79
Copy link
Contributor Author

Thanks @nvdaes, I have accepted this invitation.
The stable branch was already up-to-date (with removed French translations) when you forked the repo in nvdaaddons.
So I confirm that nvdaaddons / charInfo can be included now in the translation framework.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 28, 2021

Is this repo related to text files not affected by gettext? I think it isn't. This maybe reported to translators, imo.

@CyrilleB79
Copy link
Contributor Author

@nvdaes can you clarify? I do not understand your last comment.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 28, 2021

I think this repo is intended to generate and produce po files, so, if text files that shouldn't be localized are not related to gettext, they won't produce po files and then I think you should inform translators on the translations mailing list, for example, not here.

@CyrilleB79
Copy link
Contributor Author

Yes, I will inform translators on the mailing list when this PR is merged.

The note in this PR was not intended for translators but for NVAccess people to say:
This add-on contains language folders that are not located at the standard place. But that's not a proplem for translation framework since these folders do not contain any source file for .po generation.

I hope things are clarified now.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jun 28, 2021

Ok Cyrille. Thanks

@CyrilleB79
Copy link
Contributor Author

@feerrenrut, this add-on and other ones are waiting for their inclusion in the translation framework.
Now that the various existing issues have been fixed with Windows Magnifier add-on (thanks again), do you plan to integrate soon Character Information as well as other add-ons for which inclusion was required?
Thanks.

@feerrenrut
Copy link
Contributor

I have set this up, but there is an error, @nvdaes nvaccessAuto needs permission to push to https://github.com/nvdaaddons/charInfo

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jul 21, 2021 via email

@CyrilleB79
Copy link
Contributor Author

Thanks.
More generally, shouldn't NvaccessAuto have the right for all repos in nvdaaddons account? Unless it is already the case of course.
This would prevent @nvdaes to grant new rights for each new fork.

@nvdaes
Copy link
Sponsor Collaborator

nvdaes commented Jul 21, 2021 via email

@feerrenrut
Copy link
Contributor

Just a reminder, even though it looks like we are putting work to optimize the mrconfig based translation system, we plan to move to anew more distributed approach. @CyrilleB79 you may be interested to read: https://github.com/nvaccess/translationSystem

@feerrenrut
Copy link
Contributor

Thanks for fixing the permissions @nvdaes. This addon is now registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants