Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugWarning and io log levels #103

Closed
nvaccessAuto opened this issue Jan 1, 2010 · 4 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto
Copy link

commented Jan 1, 2010

Reported by jteh on 2008-06-06 06:32
NVDA currently uses the standard log levels (debug, info, warning, error and critical). However, this does not allow for enough flexibility. There are currently quite a few warnings that most users don't care about, but we don't want them to be at the same level as the other debug messages. Also, we currently use the info level to log user experience (keyboard input, speech output, etc.), which many users don't care about either. Thus, we want to add two new levels between debug and info, debugWarning and io.

See LogLevels for information about the new usage of all log levels, including the new levels.

Tasks

  • The new levels will reside between debug and info:
    • debugWarning at level 12
    • io at level 15
  • Import all level constants (DEBUG, INFO, etc.) into logObj.Logger for ease of access. Define the new level constants there also.
  • Use logging.addLevelName() for the new levels.
  • Write methods in logObj.Logger for the new levels.
  • Convert code to new level structure as appropriate:
    • Many warning messages will become debugWarning messages.
    • Most info messages will become io messages.
@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Jan 1, 2010

Comment 2 by jteh on 2008-06-22 08:10
I'm working on this in another branch. The new log levels have been added. Tasks still to do:

  • Termination exceptions in core should be debugWarning
  • appModuleHandler info messages should all be debug
  • synthDriverHandler "loaded synth driver %s" should be debug
  • Remove info messages in api, as io should make such info obvious
  • Key presses, spoken text and beeps should be info
    Changes:
    Milestone changed from 0.6 to 0.6p2
@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Jan 1, 2010

Comment 3 by jteh (in reply to comment 2) on 2008-06-26 05:15
Replying to jteh:

  • Key presses, spoken text and beeps should be info

Correction: these should be io.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Jan 1, 2010

Comment 4 by jteh (in reply to comment 2) on 2008-07-01 12:12
The code is complete in my branch. However, it seems I contradicted most of these tasks in the actual implementation:
Replying to jteh:

  • Termination exceptions in core should be debugWarning

Made these error instead, as we really should know about these.

  • appModuleHandler info messages should all be debug

Users probably do care about loading appModules, so some of these were left as info.

  • synthDriverHandler "loaded synth driver %s" should be debug

Again, users probably care about this, so it was left as info.

  • Remove info messages in api, as io should make such info obvious

These were changed to debug instead of removed; they could be useful when debugging.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

commented Jan 1, 2010

Comment 5 by jteh on 2008-07-03 03:49
Committed in r2177.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added the task label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 0.6p2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.